Provide the session resource for input states#309687
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the proposed chat sessions provider API so that a ChatSessionInputState can expose which chat session resource it belongs to, and wires that value through the extension host implementation.
Changes:
- Add
sessionResourceto the proposedChatSessionInputStateAPI surface. - Populate
sessionResourceonChatSessionInputStateImplinstances in ext host flows that create/resolve input state.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts | Adds sessionResource to ChatSessionInputState and documents when it is undefined. |
| src/vs/workbench/api/common/extHostChatSessions.ts | Sets sessionResource on ChatSessionInputStateImpl instances when resolving input state for sessions and commands. |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 0
joshspicer
previously approved these changes
Apr 14, 2026
Yoyokrazy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DonJayamanne