Log when shell type changes for ai clis

[anthonykim1]

Coming from: #290830
and #304528

[anthonykim1]

/cc @meganrogge

[Copilot]

Pull request overview

Adds additional terminal telemetry to better understand runtime shell type detection, particularly for agentic CLIs whose identification can change after startup.

Changes:

• Log a new telemetry event (terminal/shellTypeChanged) whenever a terminal instance’s detected shellType changes.
• Prefer instance.shellType when emitting terminal/createInstance telemetry (fallback to getSanitizedShellType).
• Extend the terminal telemetry shell type allowlist with AI CLI entries (claude/codex/copilot/gemini).

Show a summary per file

File	Description
src/vs/workbench/contrib/terminal/browser/terminalTelemetry.ts	Adds shell-type-changed telemetry and adjusts shell type value selection/allowlist for terminal telemetry events.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/terminal/browser/terminalTelemetry.ts:152

• For the new terminal/shellTypeChanged event, the logged shellType is currently the raw TerminalShellType string. If this is intended to align with the existing terminal/createInstance shellType taxonomy in this file, it should be normalized/sanitized the same way (eg map gitbash -> git-bash) to avoid splitting telemetry across multiple spellings for the same shell.

		this._telemetryService.publicLog2<TerminalShellTypeChangedTelemetryData, TerminalShellTypeChangedTelemetryClassification>('terminal/shellTypeChanged', {
			shellType: new TelemetryTrustedValue(instance.shellType ?? 'unknown'),
			terminalSessionId: instance.sessionId,

• Files reviewed: 1/1 changed files
• Comments generated: 1

[github-actions]

Screenshot Changes

Base: e705c906 Current: de7f9cbb

Changed (4)

editor/inlineCompletions/other/JumpToHint/Dark

Before	After

agentSessionsViewer/NeedsInput/Light

Before	After

agentSessionsViewer/CloudProvider/Dark

Before	After

agentSessionsViewer/CloudProvider/Light

Before	After