fix: resolve NoChangeError tool name interpolation and typo#309709
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom May 1, 2026
Merged
fix: resolve NoChangeError tool name interpolation and typo#309709mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
Hi @Jah-yee, sorry I missed this when it first came in. Can you please update this to resolve the conflicts. Thanks |
Jah-yee
force-pushed
the
fix/NoChangeError-message
branch
from
cd15b08 to
5d5fd93
Compare
Jah-yee
pushed a commit
to Jah-yee/vscode-fork-jah-yee
that referenced
this pull request
May 1, 2026
- Use backticks instead of single quotes for the error message string
- Replace literal ${ToolName.ReadFile} with read_file (the actual tool name)
- Fix duplicate 'and' typo: 'and and determine' → 'and determine'
Fixes microsoft#309709
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the recovery instruction text in NoChangeError emitted by the edit/replace-string tooling in the Copilot extension, so the model receives a correct tool name and a typo-free instruction.
Changes:
- Fixes a broken tool-name interpolation in the
NoChangeErrormessage. - Fixes a duplicated “and” typo in the same message.
Use backticks for proper template literal interpolation of ${ToolName.ReadFile}.
Fix duplicate 'and and' → 'and'.
Import ToolName from registry so message stays in sync if tool name changes.
Addresses Copilot AI review feedback: keeps tool name in sync with registry.
Jah-yee
force-pushed
the
fix/NoChangeError-message
branch
from
5d5fd93 to
25c2fe3
Compare
mjbvz
approved these changes
May 1, 2026
rzhao271
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Summary
Fixes two issues in the NoChangeError message:
Broken template interpolation: The original code uses single quotes for a string containing
${ToolName.ReadFile}, but JavaScript template literals require backticks for interpolation. The model literally receives the text${ToolName.ReadFile}instead ofread_file.Typo: Fixed duplicate "and" in "re-read the file and and determine" → "re-read the file and determine".
Changes
Changed:
Use the ${ToolName.ReadFile} tool to re-read the file and and determineTo:
Use the read_file tool to re-read the file and determineThis error message is shown when the replace_string_in_file tool produces no actual change. The garbled tool name prevented the model from following the recovery instruction to re-read the file.
Warmly, RoomWithOutRoof