Handle Welcome Dialog in DevTunnel Test#309752
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
chrmarti
approved these changes
Apr 14, 2026
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithMarkdownBadge/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/ApprovalRowLongLabel/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithMarkdownBadge/Dark
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Dev Tunnel sanity test flow to reliably handle the initial “Welcome” UI so the test can proceed through GitHub authentication and subsequent workbench actions.
Changes:
- Dismiss the welcome dialog immediately after the workbench loads during tunnel connection.
- Skip the welcome-dismiss step inside
UITest.runsince it has already been handled earlier in the Dev Tunnel flow.
Show a summary per file
| File | Description |
|---|---|
| test/sanity/src/devTunnel.test.ts | Dismisses the welcome dialog before GitHub auth and avoids re-dismissing it during the subsequent UI test run. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.