Skip to content

Do not show update tooltip for disabled state more than once every 30 days#309795

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/update-tooltip-fix
Apr 14, 2026
Merged

Do not show update tooltip for disabled state more than once every 30 days#309795
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/update-tooltip-fix

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

Fixes #307492

… days

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 14, 2026 09:43
@dmitrivMS dmitrivMS added install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Apr 14, 2026
@dmitrivMS dmitrivMS enabled auto-merge (squash) April 14, 2026 09:43
@dmitrivMS dmitrivMS self-assigned this Apr 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adds a persistence-based throttle so the “updates disabled” tooltip is only shown at most once every 30 days on startup (for specific disablement reasons).

Changes:

  • Introduces a storage key + 30-day period constant for the disabled-state reminder tooltip.
  • Reads last-shown timestamp on startup to decide whether to show the tooltip.
  • Persists the “last shown” timestamp when the tooltip is shown.
Show a summary per file
File Description
src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts Adds storage-backed gating and persistence for the disabled update tooltip to limit it to once per 30 days.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 0204b2d2 Current: 0152af6d

Changed (2)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after
editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

@dmitrivMS dmitrivMS merged commit 899cb3b into main Apr 14, 2026
30 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/update-tooltip-fix branch April 14, 2026 10:16
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-update VS Code installation and upgrade system issues windows VS Code on Windows issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to prevent "Update Disabled" dialog from showing on startup?

3 participants