Update @vscode/codicons version to 0.0.46-5#309907
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Upgrades @vscode/codicons to 0.0.46-5 to pick up the newer codicon set and maintain compatibility.
Changes:
- Bump
@vscode/codiconsfrom^0.0.46-1to^0.0.46-5in the rootpackage.json - Bump
@vscode/codiconsfrom^0.0.46-1to^0.0.46-5inremote/web/package.json
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| remote/web/package.json | Updates the codicons dependency version used by the remote web package. |
| package.json | Updates the codicons dependency version used at the repo root. |
Files not reviewed (1)
- remote/web/package-lock.json: Language not supported
| "@parcel/watcher": "^2.5.6", | ||
| "@types/semver": "^7.5.8", | ||
| "@vscode/codicons": "^0.0.46-1", | ||
| "@vscode/codicons": "^0.0.46-5", |
There was a problem hiding this comment.
The PR description states that package-lock.json is also upgraded, but no package-lock.json diff is included in the reviewed changes. If this repo uses npm lockfiles, please include the corresponding lockfile update (or adjust the PR description to match what’s actually changed).
| "@microsoft/1ds-core-js": "^3.2.13", | ||
| "@microsoft/1ds-post-js": "^3.2.13", | ||
| "@vscode/codicons": "^0.0.46-1", | ||
| "@vscode/codicons": "^0.0.46-5", |
There was a problem hiding this comment.
If the goal is specifically to move to 0.0.46-5 for compatibility, using a caret range (^0.0.46-5) can allow future installs to resolve to a different version than the one intended by this PR. Consider pinning to an exact version (0.0.46-5) to make the declared dependency match the PR intent (the lockfile will still control installs, but pinning reduces drift when lockfiles are regenerated).
| "@vscode/codicons": "^0.0.46-5", | |
| "@vscode/codicons": "0.0.46-5", |
Upgrade the @vscode/codicons package to version 0.0.46-5 in both package.json and package-lock.json files to ensure compatibility and access to the latest features. No additional testing is required beyond standard functionality checks.