sessions: default notifications to top-right#309928
Merged
hawkticehurst merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Set the sessions workbench default for `workbench.notifications.position` to `top-right` so notification toasts open in the upper-right corner without changing the main workbench default. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Sessions app’s default workbench configuration so toast notifications appear in the top-right by default, without affecting the regular VS Code workbench defaults.
Changes:
- Set the Sessions-only default for
workbench.notifications.positiontotop-right - Document the Sessions-specific notification default in
src/vs/sessions/LAYOUT.md - Add a changelog entry to the Sessions layout document
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts | Adds a Sessions-scoped default configuration for top-right notification positioning. |
| src/vs/sessions/LAYOUT.md | Documents the Sessions-specific default and records it in the layout change log. |
Contributor
rzhao271
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workbench.notifications.positiontotop-rightvs/sessionsso the regular workbench default is unchangedsrc/vs/sessions/LAYOUT.mdNotes for Reviewers
npm run compile-check-ts-nativeis currently failing on unrelated pre-existing errors insrc/vs/platform/agentHost/node/copilot/*Why
The sessions/agents app should show notification toasts in the top-right corner by default without affecting notification placement elsewhere in VS Code.