Skip to content

sessions: default notifications to top-right#309928

Merged
hawkticehurst merged 1 commit intomainfrom
agents/external-snake
Apr 14, 2026
Merged

sessions: default notifications to top-right#309928
hawkticehurst merged 1 commit intomainfrom
agents/external-snake

Conversation

@hawkticehurst
Copy link
Copy Markdown
Member

Summary

  • set the sessions app default workbench.notifications.position to top-right
  • keep the change scoped to vs/sessions so the regular workbench default is unchanged
  • document the sessions-specific notification default in src/vs/sessions/LAYOUT.md

Notes for Reviewers

  • repo-wide npm run compile-check-ts-native is currently failing on unrelated pre-existing errors in src/vs/platform/agentHost/node/copilot/*
  • hygiene passed for the touched sessions files

Why

The sessions/agents app should show notification toasts in the top-right corner by default without affecting notification placement elsewhere in VS Code.

Set the sessions workbench default for `workbench.notifications.position` to `top-right` so notification toasts open in the upper-right corner without changing the main workbench default.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 14, 2026 17:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Sessions app’s default workbench configuration so toast notifications appear in the top-right by default, without affecting the regular VS Code workbench defaults.

Changes:

  • Set the Sessions-only default for workbench.notifications.position to top-right
  • Document the Sessions-specific notification default in src/vs/sessions/LAYOUT.md
  • Add a changelog entry to the Sessions layout document

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts Adds a Sessions-scoped default configuration for top-right notification positioning.
src/vs/sessions/LAYOUT.md Documents the Sessions-specific default and records it in the layout change log.

@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: ad2f77ef Current: 17568fe6

Changed (1)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after

@hawkticehurst hawkticehurst merged commit 5abe4b0 into main Apr 14, 2026
44 of 45 checks passed
@hawkticehurst hawkticehurst deleted the agents/external-snake branch April 14, 2026 20:42
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants