cancel token #309936
Merged
meganrogge merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates terminal chat output monitoring to ensure an in-progress monitoring loop is properly cancelled before starting a new one, addressing issue #309362.
Changes:
- Ensure any existing monitoring run is cancelled (so waiting promises can resolve) before starting a new monitoring loop.
- Update comments to explain why cancellation is needed prior to disposal.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts | Cancels/disposes an existing monitoring CTS before creating a new one to avoid concurrent monitoring loops. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
…r/tools/monitoring/outputMonitor.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Yoyokrazy
approved these changes
Apr 14, 2026
Contributor
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #309362