Make sure input state is populated even if you're not using the getChatSessionInputState api#309943
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 14, 2026
Merged
Conversation
…hatSessionInputState` api
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Ensures the chat session input state is populated from initial session options even when an extension controller does not implement getChatSessionInputState.
Changes:
- Precomputes
previousInputStatefrom controller option groups andrequest.initialSessionOptions. - Reuses
previousInputStatewhen callinggetChatSessionInputState(avoid duplicate creation). - Falls back to
previousInputState(instead of an empty state) whengetChatSessionInputStateis not implemented.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/api/common/extHostChatSessions.ts | Uses initial session options to populate the input state even without the getChatSessionInputState API, and avoids recomputing previous state. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
justschen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DonJayamanne Not sure if this would explain the behavior you were seeing but it could have caused an issue like it