Try fixing chat session content being retained#309993
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 14, 2026
Merged
Conversation
We only want to retain this while the session is ongoing or it's open in a panel/editor. The panel case wdidn't seem to be handling this
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR aims to prevent chat session content from being retained longer than necessary by ensuring contributed “untitled” sessions are properly committed to a real resource and by updating the view pane when such a commit happens.
Changes:
- Wrap contributed-session “commit to real resource” logic in
sendRequestand add cleanup via a disposable model reference. - Emit a “session committed” event during the untitled-to-real session transition.
- Update
ChatViewPaneto react to committed sessions by reloading and showing the committed model.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts | Introduces a commit flow for untitled contributed sessions and attempts to dispose the temporary model reference to avoid retention. |
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts | Listens for session-commit events and swaps the pane’s model to the committed session resource. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
DonJayamanne
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only want to retain this while the session is ongoing or it's open in a panel/editor. The panel case wdidn't seem to be handling this