Agents - fix issue with the editor part being hidden when the modal editor (ex: settings) opens#310540
Merged
Agents - fix issue with the editor part being hidden when the modal editor (ex: settings) opens#310540
Conversation
…ditor (ex: settings) opens
Contributor
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
blocks-ci screenshots changed
Replace the contents of test/componentFixtures/blocks-ci-screenshots.md with:
Updated blocks-ci-screenshots.md
<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Sessions (Agents) workbench behavior where opening a modal editor (e.g. Settings) incorrectly hides an already-visible main editor part, and updates the Sessions layout spec accordingly.
Changes:
- Adjusts
onWillOpenEditorhandling so only opens targeting a main editor group can affect main editor-part visibility; modal opens no longer hide it. - Updates
LAYOUT.mdto reflect that the editor part is hidden by default but can be revealed by explicit main-part editor workflows.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/browser/workbench.ts |
Changes editor-open listener logic to ignore modal editor opens when deciding whether to reveal/hide the main editor part. |
src/vs/sessions/LAYOUT.md |
Updates the layout diagram and narrative to describe the hidden-by-default editor part and how explicit main-part opens can reveal it. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexdima
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.