Conversation
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/NeedsInput/Light
| Before | After |
|---|---|
 |
 |
blocks-ci screenshots changed
Replace the contents of test/componentFixtures/blocks-ci-screenshots.md with:
Updated blocks-ci-screenshots.md
<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
There was a problem hiding this comment.
Pull request overview
Updates the repository’s .github/CODENOTIFY configuration to reduce notification volume by removing a large set of path-to-owner mappings (notably many entries previously mapped to @bpasero), thereby narrowing which changes trigger automatic pings.
Changes:
- Removed many
src/vs/base/**,src/vs/platform/**, andsrc/vs/workbench/**notification ownership entries. - Adjusted remaining ownership for a few paths (e.g.
src/vs/code/**,src/vs/workbench/services/dialogs/**,src/vs/workbench/services/views/**).
Show a summary per file
| File | Description |
|---|---|
| .github/CODENOTIFY | Reduces CODE-notify ownership mappings across large parts of the codebase to lower notification volume. |
Copilot's findings
Comments suppressed due to low confidence (2)
.github/CODENOTIFY:22
- Most
src/vs/platform/**notification mappings were removed here, leaving large parts of the platform layer without any CODE-notify owner. If the intent is only to reduce pings to a specific person, consider replacing the removed entries with an alternative owner (team alias, on-call rotation) rather than dropping coverage entirely, to avoid missing review/triage for platform changes.
# Platform
src/vs/platform/browserView/** @kycutler @jruales
src/vs/platform/quickinput/** @TylerLeonhardt
src/vs/platform/secrets/** @TylerLeonhardt
src/vs/platform/terminal/electron-main/** @anthonykim1
src/vs/platform/terminal/node/** @anthonykim1
src/vs/platform/actions/common/menuService.ts @jrieken
src/vs/platform/instantiation/** @jrieken
.github/CODENOTIFY:42
- The previous Workbench ownership coverage appears to have been largely removed (workbench core + many services/contrib areas). As written, many
src/vs/workbench/**changes will no longer trigger notifications. To keep the “reduce overload” goal without losing coverage, consider adding higher-level patterns (e.g.src/vs/workbench/common/**,src/vs/workbench/browser/**, etc.) to appropriate owners/teams and then selectively excluding only the paths that were actually too noisy.
# Workbench Services
src/vs/workbench/services/authentication/** @TylerLeonhardt
src/vs/workbench/services/browserView/** @kycutler @jruales
src/vs/workbench/services/dialogs/** @alexr00
src/vs/workbench/services/editor/common/customEditorLabelService.ts @benibenj
src/vs/workbench/services/languageDetection/** @TylerLeonhardt
src/vs/workbench/services/views/** @sandy081 @benibenj
# Workbench Contributions
src/vs/workbench/contrib/authentication/** @TylerLeonhardt
src/vs/workbench/contrib/browserView/** @kycutler @jruales
- Files reviewed: 1/1 changed files
- Comments generated: 2
| # Base Utilities | ||
| src/vs/base/common/extpath.ts @bpasero | ||
| src/vs/base/common/fuzzyScorer.ts @bpasero | ||
| src/vs/base/common/glob.ts @bpasero | ||
| src/vs/base/common/oauth.ts @TylerLeonhardt | ||
| src/vs/base/common/path.ts @bpasero | ||
| src/vs/base/common/stream.ts @bpasero | ||
| src/vs/base/common/uri.ts @jrieken | ||
| src/vs/base/browser/domSanitize.ts @mjbvz | ||
| src/vs/base/node/pfs.ts @bpasero | ||
| src/vs/base/node/unc.ts @bpasero | ||
| src/vs/base/parts/contextmenu/** @bpasero | ||
| src/vs/base/parts/ipc/** @bpasero | ||
| src/vs/base/parts/quickinput/** @TylerLeonhardt |
There was a problem hiding this comment.
This change removes notification ownership for several core src/vs/base/** areas (e.g. extpath.ts, glob.ts, stream.ts, pfs.ts, and multiple parts/** directories). With the current entries, many Base changes will no longer notify anyone at all. Consider adding a broader catch-all (e.g. src/vs/base/**) to a team/rotation handle, or re-adding ownership for the removed paths while narrowing only the noisy subareas, so changes don’t become untriaged.
This issue also appears in the following locations of the same file:
- line 15
- line 32
| # Base Utilities | ||
| src/vs/base/common/extpath.ts @bpasero | ||
| src/vs/base/common/fuzzyScorer.ts @bpasero | ||
| src/vs/base/common/glob.ts @bpasero | ||
| src/vs/base/common/oauth.ts @TylerLeonhardt |
There was a problem hiding this comment.
The PR description is currently empty. Since this change alters notification routing for large parts of the repo, please add a short rationale (what overload is being reduced), the intended new ownership model (who should be notified instead), and a quick way to validate the change (e.g. an example path → expected notify targets).
No description provided.