fix(workbench): guard BannerPart.show against calls before createContentArea (#310358)#310825
Open
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(workbench): guard BannerPart.show against calls before createContentArea (#310358)#310825maruthang wants to merge 1 commit intomicrosoft:mainfrom
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What —
BannerPart.show()now no-ops when the banner hasn't been rendered yet, instead of throwing onclearNode(undefined).Why —
WorkspaceTrustManagementService.onDidChangeTrustcan fire its subscriber (which callsBannerPart.show()) during startup beforecreateContentArea()runs. The first line ofshow()dereferencesthis.element, producingTypeError: Cannot read properties of undefined (reading 'firstChild')(#310358).How — Added
if (!this.element) return;at the top ofshow(). Once the banner is rendered, behavior is unchanged.Test plan — New
bannerPart.test.tsinstantiatesBannerPart, callsshow(...)beforecreate(...), and asserts no throw. Pre-fix this failed withclearNode(undefined).Fixes #310358