Skip to content

move contributed dropdowns to secondary inputbar#310958

Merged
justschen merged 7 commits intomainfrom
justin/aegislash-shield
Apr 22, 2026
Merged

move contributed dropdowns to secondary inputbar#310958
justschen merged 7 commits intomainfrom
justin/aegislash-shield

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

@justschen justschen commented Apr 17, 2026

moves worktree, edit automatically, etc (anything that is extension contributed), into secondary toolbar

Copilot AI review requested due to automatic review settings April 17, 2026 09:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the chat input UI so contributed/session-related dropdowns (e.g. session option-group pickers) are placed on the secondary input bar, with updated layout styling and menu placements to support the new arrangement.

Changes:

  • Update chat widget CSS to make the secondary input toolbar flex correctly and to style session picker items when rendered there.
  • Update ChatInputPart to render session option-group pickers in the secondary toolbar (for non-cloud sessions) and enable responsive overflow behavior there.
  • Adjust chat execute action menu registrations/orders to place pickers on ChatInputSecondary vs ChatInput depending on session type.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Layout/styling updates for session pickers when hosted in the secondary input toolbar.
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Moves/consolidates picker rendering logic across primary/secondary toolbars; adds responsive overflow handling.
src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts Re-targets menu contributions (and ordering) so pickers appear in the intended toolbar.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
Comment thread src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 19, 2026

Screenshot Changes

Base: ad531180 Current: 98155e76

Changed (4)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after
editor/inlineChatAffordance/InlineChatOverlay/Light
Before After
before after
editor/inlineCompletions/other/JumpToHint/Light
Before After
before after
editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

@justschen justschen marked this pull request as ready for review April 22, 2026 05:00
@justschen justschen enabled auto-merge (squash) April 22, 2026 05:02
@justschen justschen merged commit 42fa383 into main Apr 22, 2026
26 checks passed
@justschen justschen deleted the justin/aegislash-shield branch April 22, 2026 05:28
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants