Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a focus-stealing issue where an embedded browser view can reclaim focus from a newly created VS Code window (e.g. when creating a new window via Quick Pick), aligning browser focus behavior with expected multi-window UX.
Changes:
- Add an optional
force?: booleanparameter to the browser view focus APIs (model + service). - Update the Electron main-process
BrowserView.focusimplementation to avoid focusing the webContents unless its hosting window is already focused (unlessforceis set).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/common/browserView.ts | Extends the workbench-facing model API to allow optional forced focus. |
| src/vs/platform/browserView/common/browserView.ts | Extends the platform service contract with an optional force focus flag and documents its intent. |
| src/vs/platform/browserView/electron-main/browserViewMainService.ts | Plumbs the optional force flag through the main-process service layer. |
| src/vs/platform/browserView/electron-main/browserView.ts | Implements the new focus behavior to prevent cross-window focus stealing by default. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
roblourens
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311069