Filter Copilot sessions by local data#311097
Merged
roblourens merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Only list Copilot SDK sessions that already have Agent Host session data, so sessions created by other Copilot CLI agents are filtered out without creating databases during listing. (Written by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
Filters Copilot SDK session listing in the agent host so that only sessions with existing local Agent Host session data (session DB) appear in the Agents window, avoiding side effects (DB creation / project metadata writes) during session enumeration.
Changes:
- Gate
CopilotAgent.listSessions()on an existing session database viaISessionDataService.tryOpenDatabase()(and only then resolve/store project info). - Introduce an injectable
ICopilotClientsurface + factory hook to enable fakes in unit tests. - Add focused unit tests using a fake Copilot client and in-memory
SessionDatabaseinstances to verify ownership filtering and metadata reads.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/copilot/copilotAgent.ts | Adds injectable Copilot client surface and filters session listing to only sessions with existing DB-backed metadata. |
| src/vs/platform/agentHost/test/node/copilotAgent.test.ts | Adds unit coverage validating session filtering by DB existence and metadata read behavior without DB creation. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
bryanchen-d
approved these changes
Apr 17, 2026
rzhao271
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change filters Copilot SDK sessions to only list sessions that already have Agent Host session data. That keeps sessions created by other Copilot CLI agents out of the Agents window without creating per-session databases during listing.
Summary:
Validation:
(Written by Copilot)