Skip to content

show animation around chat input while working#311125

Merged
justschen merged 9 commits intomainfrom
justin/aromatisse
Apr 21, 2026
Merged

show animation around chat input while working#311125
justschen merged 9 commits intomainfrom
justin/aromatisse

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

@justschen justschen commented Apr 18, 2026

Screen.Recording.2026-04-17.at.2.48.46.AM.mov

gated under the setting chat.progressBorder.enabled

Copilot AI review requested due to automatic review settings April 18, 2026 00:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2026

Screenshot Changes

Base: a1d3ff15 Current: b7807414

Changed (1)

agentSessionsViewer/NeedsInput/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an optional “developer joy” visual treatment to the Chat input while an agent request is in progress, alongside some related chat UI styling tweaks and settings documentation updates.

Changes:

  • Introduces chat.developerJoy.enabled and toggles a working CSS state on the chat input while requests are in progress.
  • Adds CSS for an animated gradient border + glow, plus some secondary-toolbar/session-picker layout adjustments.
  • Updates chat agent network filter setting descriptions and removes incremental-rendering settings (currently leaving dangling references).
Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/constants.ts Adds DeveloperJoy setting id; removes incremental rendering enum entries (currently breaks downstream references).
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Adds animated “working” border/glow styles and adjusts secondary toolbar/session picker styling.
src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts Toggles working class based on DeveloperJoy and request-in-progress state.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Registers DeveloperJoy; removes incremental rendering settings; updates network filter setting descriptions.
build/lib/stylelint/vscode-known-variables.json Allows the new --chat-input-anim-angle custom property for stylelint.

Copilot's findings

  • Files reviewed: 5/5 changed files
  • Comments generated: 4

Comment thread src/vs/workbench/contrib/chat/common/constants.ts
Comment thread src/vs/workbench/contrib/chat/browser/chat.contribution.ts
Comment thread src/vs/workbench/contrib/chat/browser/chat.contribution.ts
Comment thread src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 10/10 changed files
  • Comments generated: 4

Comment thread src/vs/workbench/contrib/chat/browser/widget/media/chat.css
Comment thread src/vs/workbench/contrib/chat/browser/chat.contribution.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/chat.contribution.ts
Comment thread src/vs/workbench/contrib/chat/browser/widget/media/chat.css Outdated
@justschen justschen changed the title very serious developer joy pull request show animation around chat input while working Apr 21, 2026
@justschen justschen marked this pull request as ready for review April 21, 2026 04:06
@justschen justschen enabled auto-merge (squash) April 21, 2026 04:26
@justschen justschen merged commit 1a39bed into main Apr 21, 2026
26 checks passed
@justschen justschen deleted the justin/aromatisse branch April 21, 2026 05:07
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants