feat: make empty editor hint links keyboard accessible#311175
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
feat: make empty editor hint links keyboard accessible#311175Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
) Add tabIndex and Enter/Space key handlers to action links in formattedTextRenderer, enabling keyboard navigation to 'Select a language' and other hints in empty editor. Fixes microsoft#132085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Make empty editor hint links keyboard accessible
Problem
When creating a new untitled file in VS Code, the "Select a language" hint is rendered as a clickable link, but it cannot be reached by pressing Tab. This is an accessibility issue for keyboard users.
Root Cause
The
renderFormattedTextfunction insrc/vs/base/browser/formattedTextRenderer.tscreates<a>elements for action links (like[[Select a language]]) without settingtabIndex, making them inaccessible via keyboard navigation.Solution
src/vs/base/browser/formattedTextRenderer.ts: AddedtabIndex = 0to action anchors and added akeydownevent handler for Enter and Space keys to trigger the link action.src/vs/workbench/contrib/codeEditor/browser/emptyTextEditorHint/emptyTextEditorHint.css: Added:focusstyling to provide visual feedback when the link is focused via keyboard.Changes
src/vs/base/browser/formattedTextRenderer.ts: +7 linessrc/vs/workbench/contrib/codeEditor/browser/emptyTextEditorHint/emptyTextEditorHint.css: +5 linesTesting
Related Issue
Fixes #132085