Fix devcontainer check-requirements-linux.sh to handle quoted ID values in /etc/os-release#311182
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix devcontainer check-requirements-linux.sh to handle quoted ID values in /etc/os-release#311182Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…es in /etc/os-release The script failed to parse OS_ID on Rocky Linux 8.5 where /etc/os-release uses quoted values (e.g., ID="rocky"). The grep+sed approach only matched unquoted formats. Fix by sourcing /etc/os-release directly, which handles both quoted and unquoted values correctly. Fixes microsoft#232159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Summary
The devcontainer setup script
check-requirements-linux.shfails to parseOS_IDon Rocky Linux 8.5 because it uses quoted values in/etc/os-release(e.g.,ID="rocky").Root Cause
The original grep+sed approach:
OS_ID="$(cat /etc/os-release | grep -Eo 'ID=([^"]+)' | sed -n '1s/ID=//p')"This only matches unquoted formats (
ID=rocky) and returns empty for quoted formats (ID="rocky"), causing the script to exit with code 1.Fix
Use
source /etc/os-releasewhich properly handles both quoted and unquoted values:OS_ID=$(source /etc/os-release && echo $ID)This runs in a subshell so it doesn't pollute the current shell environment.
Testing
Verified the fix works correctly:
OS_ID=''(empty/fail)OS_ID='rocky'✓OS_ID='rocky'✓Related
Fixes #232159
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof