Skip to content

better padding for reasoning when we have persistent progress#311272

Merged
justschen merged 1 commit intomainfrom
justin/inkay
Apr 20, 2026
Merged

better padding for reasoning when we have persistent progress#311272
justschen merged 1 commit intomainfrom
justin/inkay

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

removes bottom padding while streaming since thinking has a little space on the botto anyways

Copilot AI review requested due to automatic review settings April 19, 2026 21:50
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 0c576529 Current: 845fb446

Changed (1)

agentSessionsViewer/ApprovalRowLongLabel/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the chat “thinking” UI spacing in fixed-scrolling mode when persistent progress details are shown, reducing extra vertical gap during streaming.

Changes:

  • Add a chat-thinking-persistent-streaming state class during active streaming when persistent progress details are enabled (fixed-scrolling mode).
  • Remove the state class when streaming completes / titles are finalized.
  • Apply CSS to remove the default bottom margin for that state, reducing extra spacing while streaming.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatThinkingContent.css Adds a state-specific rule to remove bottom margin while persistently streaming in fixed-scrolling mode.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts Toggles the new state class on the thinking container during streaming and clears it on completion/fallback title finalization.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@justschen justschen enabled auto-merge (squash) April 19, 2026 22:19
@justschen justschen merged commit 96b1003 into main Apr 20, 2026
30 checks passed
@justschen justschen deleted the justin/inkay branch April 20, 2026 00:35
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants