heap-snapshot-analysis skill improvements#311283
Merged
roblourens merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithDiffChanges/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithDiffChanges/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds streaming-based utilities and updated guidance for analyzing very large (>2 GiB) V8 heap snapshots in the heap-snapshot-analysis skill, avoiding full-file buffering approaches that can exceed Node’s Buffer limits.
Changes:
- Introduces
streamSnapshot.mjswith byte-scanning and numeric-array streaming helpers for heap snapshot sections. - Updates
SKILL.mdwith guidance and example workflow for >2 GiB snapshots, including offset scanning and streaming tuple parsing. - Expands investigation guidance with an additional “false retainer” category related to DevTools debugger handles.
Show a summary per file
| File | Description |
|---|---|
| .github/skills/heap-snapshot-analysis/helpers/streamSnapshot.mjs | New streaming primitives for locating sections and incrementally parsing numeric arrays (plus meta/strings helpers). |
| .github/skills/heap-snapshot-analysis/SKILL.md | Documentation updates describing when/why to use streaming scripts and how to structure large-snapshot workflows. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
Address review feedback by honoring short reads, documenting tuple reuse with an opt-in copy mode, and guarding eager string parsing for large snapshots. (Written by Copilot)
rebornix
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.