Fix disposed SCM source control retention#311284
Merged
Conversation
Remove disposed source controls from extension-host SCM bookkeeping so they no longer retain repository state after unregistering from the main thread. (Written by Copilot)
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an extension-host SCM retention/leak by ensuring disposed SourceControl instances are removed from ExtHostSCM bookkeeping, allowing disposed repositories and related state to be garbage-collected.
Changes:
- Remove disposed source controls from both handle-based (
_sourceControls) and extension-based (_sourceControlsByExtension) maps ononDidDispose. - Add a regression unit test asserting disposed source controls no longer appear in extension bookkeeping (
getLastInputBoxbecomesundefined).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/api/common/extHostSCM.ts | Hooks onDidDispose to delete disposed providers from ExtHostSCM maps to prevent retention. |
| src/vs/workbench/api/test/common/extHostSCM.test.ts | Adds a focused regression test validating extension bookkeeping is cleared after disposal. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
jrieken
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an extension-host SCM bookkeeping leak where disposed source controls remained reachable from
ExtHostSCMafter they had been unregistered from the main thread.Disposed source controls are now removed from both handle-based and extension-based bookkeeping when
onDidDisposefires. This allows disposed Git repositories and their refs/history/artifact state to be collected instead of staying alive through stale SCM provider references.Fixes #311282
Validation:
VS Code - Buildtask output was clean for Core Transpile, Core Typecheck, Ext Build, and Copilot Build.disposed source controls are removed from extension bookkeeping.@typescript-eslint/typescript-estree.(Written by Copilot)