Skip to content

Agents: Refactor SessionsView UI and improve action order#311330

Merged
mrleemurray merged 4 commits intomainfrom
mrleemurray/session-search-reorder
Apr 20, 2026
Merged

Agents: Refactor SessionsView UI and improve action order#311330
mrleemurray merged 4 commits intomainfrom
mrleemurray/session-search-reorder

Conversation

@mrleemurray
Copy link
Copy Markdown
Contributor

@mrleemurray mrleemurray commented Apr 20, 2026

This pull request refactors and improves the Sessions View header in both functionality and visual consistency. The main changes include extracting the "New Session" button logic into a dedicated method for better code organization, updating the header action order, and refining the appearance of the find widget's close button to match other toolbar buttons.

UI/UX Improvements:

  • The find widget's close button in the sessions view now matches the size and style of the header toolbar action buttons for a more consistent look (sessionsViewPane.css).

Code Refactoring & Organization:

  • The logic for creating the "New Session" button has been moved into a new private method createNewSessionButton, simplifying the main constructor and improving maintainability (sessionsView.ts).
  • The header action order is now: New, Filter, Search, for better usability and visual clarity (sessionsView.ts).

Menu and Action Ordering:

  • The "Filter Sessions" submenu and "Find Session" action have been reordered in the header menu for improved navigation, with "Filter" now before "Find" (sessionsViewActions.ts).

mrleemurray and others added 3 commits April 20, 2026 09:42
…get close button size with toolbar actions

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 20, 2026 08:51
@mrleemurray mrleemurray enabled auto-merge (squash) April 20, 2026 08:51
@mrleemurray mrleemurray self-assigned this Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Screenshot Changes

Base: 2ac46efe Current: 301e47b3

Changed (2)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after
editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the SessionsView header actions to improve UI consistency and action ordering in the Agents Sessions window (vs/sessions), including a small styling tweak to better align the find widget close button with toolbar actions.

Changes:

  • Reorders header toolbar actions so Filter appears before Search/Find.
  • Extracts the “New Session” header button creation into a dedicated helper for cleaner SessionsView construction.
  • Adjusts CSS to size the find widget close action to match header toolbar button dimensions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts Reorders SidebarSessionsHeader menu items so Filter precedes Find.
src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts Extracts/places the “New” session button before the menu-driven toolbar to achieve intended visual order.
src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css Tweaks find widget close action sizing to align with toolbar action button sizing.

Comment thread src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mrleemurray mrleemurray merged commit cc222f5 into main Apr 20, 2026
26 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/session-search-reorder branch April 20, 2026 09:41
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants