Hide review button when chat plan is collapsed#311352
Merged
DonJayamanne merged 1 commit intorelease/1.117from Apr 20, 2026
Merged
Hide review button when chat plan is collapsed#311352DonJayamanne merged 1 commit intorelease/1.117from
DonJayamanne merged 1 commit intorelease/1.117from
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily adjusts the chat plan review UI so the “Restore Size” control is hidden while the plan review is collapsed (addressing #311328), but it also includes several unrelated updates across sessions UI, terminal chat tooling, Copilot sessions metadata handling, automode request shaping, and version bumps.
Changes:
- Hide the plan review “Restore Size” button when the plan is collapsed and clear plan review state when switching sessions.
- Increase terminal tool output capture cap to 60KB and update/move truncation coverage in tests.
- Misc: sessions view header/menu ordering + CSS tweaks, unknown workspace repository URI fallback, automode model hints request change, and version bumps.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/runInTerminalHelpers.test.ts | Removes sanitize-output truncation test coverage from this suite. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/outputHelpers.test.ts | Adds coverage for 60KB output truncation + truncation marker. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalHelpers.ts | Removes sanitizeTerminalOutput and related ANSI-strip/truncation logic from this module. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/outputHelpers.ts | Raises output cap to 60KB and truncates via truncateOutputKeepingTail. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Clears plan review state when the active session changes away from stored plan review resources. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css | Adds a CSS helper class to hide the restore button. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatPlanReviewPart.ts | Toggles restore button visibility when collapsed. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts | Reorders/adjusts header menu items (Filter submenu vs Find). |
| src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts | Refactors “New” session button creation into a helper and adjusts header layout order. |
| src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css | Aligns find widget close button sizing with header toolbar actions. |
| src/vs/sessions/contrib/copilotChatSessions/test/browser/copilotChatSessionsProvider.test.ts | Adds test ensuring missing repo metadata yields a safe “unknown” repository URI. |
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts | Changes unknown repository fallback URI to unknown:/// to avoid URI path join issues. |
| package.json | Bumps repo version to 1.118.0. |
| package-lock.json | Bumps lockfile package version references to 1.118.0. |
| extensions/copilot/src/platform/endpoint/node/automodeService.ts | Changes automode request to send multiple model hints (editor adds fallback auto). |
| extensions/copilot/package.json | Bumps Copilot Chat extension version/engine and reformats some JSON arrays. |
| extensions/copilot/package-lock.json | Updates Copilot Chat lockfile version/engine metadata. |
Copilot's findings
Files not reviewed (1)
- extensions/copilot/package-lock.json: Language not supported
- Files reviewed: 15/17 changed files
- Comments generated: 2
e20f88c to
0c1d5e3
Compare
0c1d5e3 to
73f5c7c
Compare
Yoyokrazy
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311328