Skip to content

Hide review button when chat plan is collapsed#311352

Merged
DonJayamanne merged 1 commit intorelease/1.117from
don/fascinating-shrimp
Apr 20, 2026
Merged

Hide review button when chat plan is collapsed#311352
DonJayamanne merged 1 commit intorelease/1.117from
don/fascinating-shrimp

Conversation

@DonJayamanne
Copy link
Copy Markdown
Contributor

Fixes #311328

Copilot AI review requested due to automatic review settings April 20, 2026 10:36
@DonJayamanne DonJayamanne self-assigned this Apr 20, 2026
@DonJayamanne DonJayamanne changed the base branch from main to release/1.117 April 20, 2026 10:36
@DonJayamanne DonJayamanne marked this pull request as ready for review April 20, 2026 10:37
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: fd55f112 Current: c214e4b3

Changed (1)

agentSessionsViewer/NeedsInput/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR primarily adjusts the chat plan review UI so the “Restore Size” control is hidden while the plan review is collapsed (addressing #311328), but it also includes several unrelated updates across sessions UI, terminal chat tooling, Copilot sessions metadata handling, automode request shaping, and version bumps.

Changes:

  • Hide the plan review “Restore Size” button when the plan is collapsed and clear plan review state when switching sessions.
  • Increase terminal tool output capture cap to 60KB and update/move truncation coverage in tests.
  • Misc: sessions view header/menu ordering + CSS tweaks, unknown workspace repository URI fallback, automode model hints request change, and version bumps.
Show a summary per file
File Description
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/runInTerminalHelpers.test.ts Removes sanitize-output truncation test coverage from this suite.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/outputHelpers.test.ts Adds coverage for 60KB output truncation + truncation marker.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalHelpers.ts Removes sanitizeTerminalOutput and related ANSI-strip/truncation logic from this module.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/outputHelpers.ts Raises output cap to 60KB and truncates via truncateOutputKeepingTail.
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Clears plan review state when the active session changes away from stored plan review resources.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css Adds a CSS helper class to hide the restore button.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatPlanReviewPart.ts Toggles restore button visibility when collapsed.
src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts Reorders/adjusts header menu items (Filter submenu vs Find).
src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts Refactors “New” session button creation into a helper and adjusts header layout order.
src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css Aligns find widget close button sizing with header toolbar actions.
src/vs/sessions/contrib/copilotChatSessions/test/browser/copilotChatSessionsProvider.test.ts Adds test ensuring missing repo metadata yields a safe “unknown” repository URI.
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts Changes unknown repository fallback URI to unknown:/// to avoid URI path join issues.
package.json Bumps repo version to 1.118.0.
package-lock.json Bumps lockfile package version references to 1.118.0.
extensions/copilot/src/platform/endpoint/node/automodeService.ts Changes automode request to send multiple model hints (editor adds fallback auto).
extensions/copilot/package.json Bumps Copilot Chat extension version/engine and reformats some JSON arrays.
extensions/copilot/package-lock.json Updates Copilot Chat lockfile version/engine metadata.

Copilot's findings

Files not reviewed (1)
  • extensions/copilot/package-lock.json: Language not supported
  • Files reviewed: 15/17 changed files
  • Comments generated: 2

Comment thread extensions/copilot/src/platform/endpoint/node/automodeService.ts Outdated
Comment thread package.json
@DonJayamanne DonJayamanne force-pushed the don/fascinating-shrimp branch from e20f88c to 0c1d5e3 Compare April 20, 2026 18:07
@DonJayamanne DonJayamanne force-pushed the don/fascinating-shrimp branch from 0c1d5e3 to 73f5c7c Compare April 20, 2026 18:08
@DonJayamanne DonJayamanne enabled auto-merge (squash) April 20, 2026 18:09
@DonJayamanne DonJayamanne merged commit d209ec0 into release/1.117 Apr 20, 2026
26 checks passed
@DonJayamanne DonJayamanne deleted the don/fascinating-shrimp branch April 20, 2026 18:43
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Restore Size" button has no effect in expanded mode

3 participants