Skip to content

Fix model list hover for upgrade scenario#311399

Merged
lramos15 merged 2 commits intomainfrom
lramos15/tart-gull
Apr 20, 2026
Merged

Fix model list hover for upgrade scenario#311399
lramos15 merged 2 commits intomainfrom
lramos15/tart-gull

Conversation

@lramos15
Copy link
Copy Markdown
Member

Fix #311340

Copilot AI review requested due to automatic review settings April 20, 2026 16:06
@lramos15 lramos15 enabled auto-merge (squash) April 20, 2026 16:06
@lramos15 lramos15 self-assigned this Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a theming/regression issue in the ActionList hover/submenu panel used by the Copilot model picker, ensuring links in the “upgrade/unavailable model” hover content remain readable in dark themes.

Changes:

  • Style links inside the submenu hover header using textLink theme colors.
  • Avoid unnecessary submenu hide/re-show when hovering the same disabled item that has hover content.
Show a summary per file
File Description
src/vs/platform/actionWidget/browser/actionWidget.css Ensures anchor text in the submenu hover header uses theme link colors for readability.
src/vs/platform/actionWidget/browser/actionList.ts Prevents flicker/unstyled states by keeping the current hover panel alive when re-hovering the same disabled element.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lramos15 lramos15 merged commit f2576e2 into main Apr 20, 2026
26 checks passed
@lramos15 lramos15 deleted the lramos15/tart-gull branch April 20, 2026 16:45
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unreadable dark text on dark background in Copilot model picker

3 participants