feat: enable shared safestorage on windows#311418
Merged
deepak1556 merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the embedded Agents app on Windows to reuse the host VS Code safeStorage encryption key (from the host app’s Local State) to support sharing authentication between apps, and bumps Electron to a version that includes the required API.
Changes:
- Extracted and exported
getDefaultUserDataPath()to compute platform default user data locations. - Added Windows-embedded initialization path in
EncryptionMainServiceto callsafeStorage.initWithExistingKey()using the host app’sLocal State. - Updated Electron from
39.8.7→39.8.8and refreshed related manifests/checksums.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/environment/node/userDataPath.ts | Refactors default user-data-path computation into exported getDefaultUserDataPath(). |
| src/vs/platform/encryption/electron-main/encryptionMainService.ts | Initializes safeStorage with the host app’s existing key for Windows embedded scenarios. |
| package.json | Bumps Electron dependency to 39.8.8. |
| package-lock.json | Updates lockfile entries for Electron 39.8.8. |
| cgmanifest.json | Updates Electron component metadata to 39.8.8. |
| build/checksums/electron.txt | Updates Electron artifact checksums for 39.8.8. |
| .npmrc | Updates Electron build target/version and build id to 39.8.8. |
roblourens
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #308028