Skip to content

Apply class pascal cases eslint rule to all ts files#311537

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/wee-parrot
Apr 20, 2026
Merged

Apply class pascal cases eslint rule to all ts files#311537
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/wee-parrot

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Apr 20, 2026

No reason to keep this just to core

No reason to keep this just to core
Copilot AI review requested due to automatic review settings April 20, 2026 23:32
@mjbvz mjbvz enabled auto-merge April 20, 2026 23:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repo’s ESLint flat config so the @typescript-eslint/naming-convention rule enforcing PascalCase for class names is applied to all TypeScript files (not just core src/**).

Changes:

  • Removed the src/**/*.ts-scoped “vscode TS” override block.
  • Moved the class PascalCase naming-convention rule into the general TypeScript config (**/*.{ts,tsx,mts,cts}), making it apply across the repo.
Show a summary per file
File Description
eslint.config.js Broadens the class PascalCase naming rule from src/**/*.ts to the general TypeScript file glob so it applies repo-wide.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@mjbvz mjbvz merged commit 7efcd94 into microsoft:main Apr 20, 2026
30 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants