feat: enhance authentication handling for web sessions and account initialization#311538
Merged
feat: enhance authentication handling for web sessions and account initialization#311538
Conversation
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/ApprovalRowLongLabel/Dark
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts web-only behavior so the Agents (sessions) workbench can initialize account + entitlement state even when running without a remote authority, and improves the welcome walkthrough behavior when GitHub authentication sessions are lost.
Changes:
- Allow Copilot chat entitlement setup to run in the Sessions window on web-no-remote by refining the “hide on web” guard.
- Allow default account initialization to run for the Sessions window on web-no-remote (while still skipping classic vscode.dev editor).
- Add a web-only auth session watcher that re-shows the welcome walkthrough when the last GitHub session is removed.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/chat/common/chatEntitlementService.ts | Stops hiding Copilot UI for the web Sessions window when there’s no remote authority. |
| src/vs/workbench/services/accounts/browser/defaultAccount.ts | Ensures default account initialization runs in the web Sessions window (vscode.dev/agents), but remains skipped for classic web-no-remote. |
| src/vs/sessions/contrib/welcome/browser/welcome.contribution.ts | Adds web-only monitoring for GitHub session removal to clear the welcome completion marker and re-show the sign-in walkthrough. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
rebornix
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.