agentHost: fix broken state leading to misrouted messages#311572
Merged
connor4312 merged 1 commit intomainfrom Apr 21, 2026
Merged
agentHost: fix broken state leading to misrouted messages#311572connor4312 merged 1 commit intomainfrom
connor4312 merged 1 commit intomainfrom
Conversation
deepak1556
approved these changes
Apr 21, 2026
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a lifecycle ordering bug in agent-host backed chat sessions where a disposed session could remain cached (leading to subsequent messages being routed to a disposed/mismatched session).
Changes:
- Ensure
AgentHostChatSession.onWillDisposefires beforeDisposableteardown by overridingdispose(). - Add a regression test asserting
onWillDisposefires exactly once when disposing an agent-host chat session.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionHandler.ts | Fires onWillDispose before super.dispose() to allow cache eviction before teardown. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts | Adds coverage to prevent regressions in session disposal event ordering. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.