Agents - start cleaning up IChatSessionFileChange and IChatSessionFileChange2#311688
Merged
Agents - start cleaning up IChatSessionFileChange and IChatSessionFileChange2#311688
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR starts consolidating the Agents window “session changes” typing by introducing a sessions-layer alias that can represent both legacy IChatSessionFileChange and newer IChatSessionFileChange2, then updating session-facing interfaces/adapters to use that alias.
Changes:
- Add
ISessionFileChange(union ofIChatSessionFileChange | IChatSessionFileChange2) and updateIChat/ISessionto exposechangesasISessionFileChange[]. - Update
ICopilotChatSessionandAgentSessionAdapterto surfacechangesasISessionFileChange[].
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/services/sessions/common/session.ts |
Introduces ISessionFileChange and updates session/chat interfaces to use it for changes. |
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts |
Moves session provider-facing changes typing toward ISessionFileChange[] and widens AgentSessionAdapter extraction accordingly. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts:183
CopilotCLISessionnow declares_changes/changesasISessionFileChange[], but the constructor still initializes_changeswithobservableValue<readonly IChatSessionFileChange[]>(..., [])(later in the class). BecauseobservableValue’s return type is invariant (it has asetmethod), this will not type-check. Initialize_changeswithISessionFileChange[](or remove the explicit generic and let it infer from the_changesdeclaration) so the types match end-to-end.
private readonly _changes: ReturnType<typeof observableValue<readonly ISessionFileChange[]>>;
readonly changes: IObservable<readonly ISessionFileChange[]>;
- Files reviewed: 9/9 changed files
- Comments generated: 1
sandy081
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.