Only dismiss the welcome dialog in sanity tests if it is shown#311702
Merged
Only dismiss the welcome dialog in sanity tests if it is shown#311702
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates sanity UI tests to avoid blocking on the welcome dialog by making dismissal conditional, and simplifies UITest.run call sites accordingly.
Changes:
- Remove the
skipWelcomeparameter fromUITest.runand update callers. - Update
dismissWelcomeDialogto proceed when the welcome dialog is not shown (via a timeout-based check). - Adjust WSL and Dev Tunnel sanity tests to call
runwithout the extra flag.
Show a summary per file
| File | Description |
|---|---|
| test/sanity/src/uiTest.ts | Makes welcome dialog dismissal conditional and simplifies UITest.run signature. |
| test/sanity/src/wsl.test.ts | Updates the WSL sanity test to use the new UITest.run(page) signature. |
| test/sanity/src/devTunnel.test.ts | Updates the Dev Tunnel sanity test to use the new UITest.run(page) signature. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
mjbvz
previously approved these changes
Apr 21, 2026
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Co-authored-by: Copilot <copilot@github.com>
anthonykim1
previously approved these changes
Apr 21, 2026
TylerLeonhardt
previously approved these changes
Apr 21, 2026
dmitrivMS
dismissed stale reviews from TylerLeonhardt and anthonykim1
via
6c4d638
roblourens
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com