Skip to content

Agents - register the "Changes" view in the "Views" menu#311763

Merged
lszomoru merged 2 commits intomainfrom
lszomoru/xerothermic-dinosaur
Apr 22, 2026
Merged

Agents - register the "Changes" view in the "Views" menu#311763
lszomoru merged 2 commits intomainfrom
lszomoru/xerothermic-dinosaur

Conversation

@lszomoru
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 19:04
@lszomoru lszomoru enabled auto-merge (squash) April 21, 2026 19:05
@lszomoru lszomoru self-assigned this Apr 21, 2026
@lszomoru lszomoru added this to the 1.118.0 milestone Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Screenshot Changes

Base: 42fa3837 Current: ed061a0a

Changed (2)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
Before After
before after
editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Registers the Agents “Changes” view so it appears as an entry in the top-level View (menubar) menu for the Sessions window.

Changes:

  • Switch Sessions window bootstrap to load changes.contribution instead of the old changesView.contribution entrypoint.
  • Add an openCommandActionDescriptor (mnemonic title + keybinding metadata) for the Changes view to surface it in the Views menu.
Show a summary per file
File Description
src/vs/sessions/sessions.common.main.ts Updates Sessions window contributions import to load the Changes contribution module.
src/vs/sessions/contrib/changes/browser/changes.contribution.ts Adds menu registration metadata (openCommandActionDescriptor) for the Changes view, including mnemonic title and keybinding declaration.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/changes/browser/changes.contribution.ts:53

  • openCommandActionDescriptor.keybindings assigns Ctrl/Cmd+Shift+G, but changesViewActions.ts already registers the same shortcut for workbench.action.agentSessions.focusChangesView. This introduces a keybinding conflict (and may override the existing handler), making Ctrl/Cmd+Shift+G ambiguous in the Sessions window. Consider removing the keybinding here (keeping only the Views menu entry), or adjusting/removing the existing focusChangesView keybinding so there is only one binding for this chord.
  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lszomoru lszomoru merged commit b65233e into main Apr 22, 2026
39 of 41 checks passed
@lszomoru lszomoru deleted the lszomoru/xerothermic-dinosaur branch April 22, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants