Agents - register the "Changes" view in the "Views" menu#311763
Merged
Agents - register the "Changes" view in the "Views" menu#311763
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Registers the Agents “Changes” view so it appears as an entry in the top-level View (menubar) menu for the Sessions window.
Changes:
- Switch Sessions window bootstrap to load
changes.contributioninstead of the oldchangesView.contributionentrypoint. - Add an
openCommandActionDescriptor(mnemonic title + keybinding metadata) for the Changes view to surface it in the Views menu.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/sessions.common.main.ts | Updates Sessions window contributions import to load the Changes contribution module. |
| src/vs/sessions/contrib/changes/browser/changes.contribution.ts | Adds menu registration metadata (openCommandActionDescriptor) for the Changes view, including mnemonic title and keybinding declaration. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/changes/browser/changes.contribution.ts:53
openCommandActionDescriptor.keybindingsassigns Ctrl/Cmd+Shift+G, butchangesViewActions.tsalready registers the same shortcut forworkbench.action.agentSessions.focusChangesView. This introduces a keybinding conflict (and may override the existing handler), making Ctrl/Cmd+Shift+G ambiguous in the Sessions window. Consider removing the keybinding here (keeping only the Views menu entry), or adjusting/removing the existingfocusChangesViewkeybinding so there is only one binding for this chord.
- Files reviewed: 2/2 changed files
- Comments generated: 0
mjbvz
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.