sessions: simplify secondary sidebar titlebar toggle#311787
Merged
hawkticehurst merged 5 commits intomainfrom Apr 22, 2026
Merged
sessions: simplify secondary sidebar titlebar toggle#311787hawkticehurst merged 5 commits intomainfrom
hawkticehurst merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the Agents window title bar UX cleanup by turning the Changes titlebar control into a standard secondary sidebar toggle (icon-only, state indicated via icon variants) and simplifying associated styling.
Changes:
- Replace the Changes diff-stats titlebar widget with a generic secondary sidebar toggle that uses open/closed right-sidebar icon variants.
- Remove the diff-stats-specific CSS and custom action view item rendering.
- Adjust command-center title container spacing by switching from
padding-lefttomargin-left, with corresponding override when the sidebar is present.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/media/sessionsTitleBarWidget.css | Updates command-center title container spacing to use margin-left instead of padding-left. |
| src/vs/sessions/contrib/changes/browser/media/changesTitleBarWidget.css | Removes diff-stats widget styles, leaving only a spacing rule for the titlebar actions. |
| src/vs/sessions/contrib/changes/browser/changesTitleBarWidget.ts | Simplifies the Changes toggle to a standard secondary sidebar toggle with registered icon variants for open/closed states. |
| src/vs/sessions/browser/parts/media/titlebarpart.css | Removes persistent “checked” background styling for the secondary sidebar toggle while preserving hover styling. |
Replace the custom diff stats indicator (showing +insertions/-deletions) in the titlebar with a simple right sidebar toggle using layoutSidebarRight / layoutSidebarRightOff codicons to match the left sidebar toggle behavior. - Drop ChangesTitleBarActionViewItem and all diff stat rendering logic - Use icon variants (layoutSidebarRightOff / layoutSidebarRight) for toggle state instead of background toggling - Update tooltip to 'Toggle Secondary Side Bar Visibility' - Remove diff stat CSS (insertions, deletions, custom indicator styles) - Add CSS override so the right sidebar button does not show the activeBackground when toggled (relying on icon variants like the left sidebar) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Target the secondary sidebar titlebar toggle by its icon classes so it opts out of the shared checked background styling without affecting the terminal toggle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Allow the secondary sidebar titlebar toggle to keep the normal hover background when checked, while still suppressing the persistent checked background. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use margin-left for the command center title container spacing and update the sidebar-visible override to reset margin-left instead of padding-left. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hawkticehurst
force-pushed
the
agents/update-changes-sidebar-button
branch
from
fa12b09 to
9211ae0
Compare
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
@jriekenMatched files:
|
hawkticehurst
changed the base branch from
agents/update-session-app-title-bar
to
main
Member
Author
@deepak1556 / @jrieken feel free to ignore. I had Copilot make some changes that resulted in a crazy git force push that polluted the commit log for this PR. None of the files listed above have actually been changed in this PR. |
- clarify the remaining changes titlebar CSS comment - avoid command center overflow when sidebar spacing uses margin - give the changes toggle a changes-specific action title while keeping the requested secondary-sidebar tooltip text Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
roblourens
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #310014 workstream.
padding-lefttomargin-leftWhy
Notes
maindirectly and contains only the four follow-up commits for this changenpm run compile-check-ts-nativepassesnpm run hygienecurrently fails in this worktree because of pre-existingextensions/**/tsconfig.tsbuildinfohygiene errors unrelated to these changes