Skip to content

fix: post-install script doesn't check for existing sources #311795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzhao271 merged 5 commits into from
Apr 24, 2026
+26 −1
Merged

fix: post-install script doesn't check for existing sources #311795

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b9a304
fix: post-install script doesn't check for existing sources
rzhao271 Apr 21, 2026
d7a3d3c
Update resources/linux/debian/postinst.template
rzhao271 Apr 21, 2026
286e6e1
fix: also scan Dir::Etc::sourcelist in has_existing_repo_source
Copilot Apr 21, 2026
350b462
fix: check our own managed files before has_existing_repo_source
Copilot Apr 24, 2026
2ffe84e
Merge branch 'main' into rzhao271/pretty-pony
rzhao271 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion resources/linux/debian/postinst.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,35 @@ if [ "@@NAME@@" != "code-oss" ]; then
fi

# Register apt repository
eval $(apt-config shell APT_SOURCE_PARTS Dir::Etc::sourceparts/d)
eval $(apt-config shell APT_SOURCE_PARTS Dir::Etc::sourceparts/d APT_SOURCES_LIST Dir::Etc::sourcelist/f)
CODE_SOURCE_PART=${APT_SOURCE_PARTS}vscode.list
CODE_SOURCE_PART_DEB822=${APT_SOURCE_PARTS}vscode.sources

CODE_TRUSTED_PART=/usr/share/keyrings/microsoft.gpg
CODE_TRUSTED_PART_OLD="/etc/apt/trusted.gpg.d/microsoft.gpg"

has_existing_repo_source() {
for source_file in "${APT_SOURCE_PARTS}"*.list "${APT_SOURCE_PARTS}"*.sources "$APT_SOURCES_LIST"; do
if [ ! -f "$source_file" ]; then
Comment thread
rzhao271 marked this conversation as resolved.
continue
fi

# Classic apt source list entry, for example:
# deb [arch=amd64] https://packages.microsoft.com/repos/code stable main
if grep -Eiq "^[[:space:]]*deb[[:space:]].*https://packages\\.microsoft\\.com/repos/code/?([[:space:]]|$)" "$source_file"; then
return 0
fi

# DEB822 source entry, for example:
# URIs: https://packages.microsoft.com/repos/code
if grep -Eiq "^[[:space:]]*URIs:[[:space:]]*https://packages\\.microsoft\\.com/repos/code/?([[:space:]]|$)" "$source_file"; then
return 0
fi
done

return 1
}

# RET seems to be true by default even after db_get is called on a first install.
RET='true'
if [ -e '/usr/share/debconf/confmodule' ]; then
Expand All @@ -54,6 +76,9 @@ if [ "@@NAME@@" != "code-oss" ]; then
elif [ -f "$CODE_SOURCE_PART_DEB822" ]; then
# The user is on the new DEB822 format, but refresh the file contents
WRITE_SOURCE='yes'
elif has_existing_repo_source; then
# Another source list file already maps to this repository
WRITE_SOURCE='no'
elif [ -f /etc/rpi-issue ]; then
# Do not write on Raspberry Pi OS
# https://github.com/microsoft/vscode/issues/118825
Expand Down
Loading