prompt validator: improve error reporting#311876
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Improves prompt file validation diagnostics by making file-reference checks more precise and adding logging for unexpected failures during existence checks.
Changes:
- Inject
ILogServiceintoPromptValidatorto enable logging. - Only emit a “file not found” marker when
fileService.exists(...)returnsfalse(avoids false positives). - Add a warning log when file existence checks throw.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptValidator.ts | Refines file-reference validation logic and logs failures during existence checks. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
141
to
+142
| } catch { | ||
| this.logger.warn(`Error checking existence of file reference '${ref.content}' resolved to '${resolved.toString()}' in prompt file '${promptAST.uri.toString()}'`); |
There was a problem hiding this comment.
The catch here swallows exceptions from fileService.exists and only logs a generic string. Please capture the error (e.g. catch (err)) and pass it to ILogService.warn so stack/details are preserved; additionally consider reporting a marker when the existence check fails so users still get feedback when validation can’t be performed.
Suggested change
| } catch { | |
| this.logger.warn(`Error checking existence of file reference '${ref.content}' resolved to '${resolved.toString()}' in prompt file '${promptAST.uri.toString()}'`); | |
| } catch (err) { | |
| this.logger.warn(`Error checking existence of file reference '${ref.content}' resolved to '${resolved.toString()}' in prompt file '${promptAST.uri.toString()}'`, err); | |
| report(toMarker(localize('promptValidator.fileReferenceValidationFailed', "Could not validate file reference '{0}'.", ref.content), ref.range, MarkerSeverity.Warning)); |
alexdima
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.