Skip to content

promptValidator: log error #311899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeschli merged 2 commits into from
Apr 26, 2026
+2 −2
Merged

promptValidator: log error #311899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ec6b1
promptValidator: log error
aeschli Apr 22, 2026
9d003a8
Merge branch 'main' into aeschli/ltd-cricket-358
aeschli Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ export class PromptValidator {
const loc = this.labelService.getUriLabel(resolved);
report(toMarker(localize('promptValidator.fileNotFound', "File '{0}' not found at '{1}'.", ref.content, loc), ref.range, MarkerSeverity.Warning));
}
} catch {
this.logger.warn(`Error checking existence of file reference '${ref.content}' resolved to '${resolved.toString()}' in prompt file '${promptAST.uri.toString()}'`);
} catch (e) {
this.logger.warn(`Error checking existence of file reference '${ref.content}' resolved to '${resolved.toString()}' in prompt file '${promptAST.uri.toString()}': ${e.message}`);
Comment on lines +175 to +176
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this catch block, interpolating ${e.message} assumes the thrown value has a message property; if something throws null/undefined this will itself throw while handling the error, and for non-Error throws it may log undefined and lose stack details. Prefer using the existing toErrorMessage(e, true) helper (or otherwise safely stringify the caught value) so logging is robust and includes useful diagnostics.

Copilot uses AI. Check for mistakes.
}
})());
}
Expand Down
Loading