Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Linux support for opening the “Agents Application/Agents window” and centralizes the command ID + enablement precondition into shared chat constants so UI entry points use consistent gating.
Changes:
- Added
OPEN_AGENTS_WINDOW_COMMAND_IDandOPEN_AGENTS_WINDOW_PRECONDITIONtochat/common/constants.tsand updated callers to use them. - Disabled
--agentsstartup handling on Linux in the Electron main process (launchMainService.ts,app.ts). - Updated the tip catalog to reference the command ID via localization placeholders.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts | Switched command ID/precondition to shared constants (but import path is currently incorrect). |
| src/vs/workbench/contrib/chat/common/constants.ts | Introduced shared command ID + precondition (currently missing stable-quality gating). |
| src/vs/workbench/contrib/chat/browser/chatTipCatalog.ts | Uses shared precondition and command ID placeholder for the “Agents Application” tip. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsBanner.ts | Uses shared command ID (but import path is currently incorrect; banner logic also doesn’t exclude Linux). |
| src/vs/platform/launch/electron-main/launchMainService.ts | Prevents --agents from opening Agents window on Linux. |
| src/vs/code/electron-main/app.ts | Prevents --agents from opening Agents window on Linux during app startup. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsBanner.ts:40
- With Linux support being removed,
canShowAgentsBannershould also account for Linux. Right now it only checksquality !== 'stable'and command registration; on Linux Insiders the command is still registered, so the banner would show and clicking it will still executeworkbench.action.openAgentsWindow. Consider adding an explicit!isLinux(or equivalent) gate here to match the new platform restrictions.
export function canShowAgentsBanner(productService: IProductService): boolean {
return productService.quality !== 'stable'
&& !!CommandsRegistry.getCommand(OPEN_AGENTS_WINDOW_COMMAND_ID);
- Files reviewed: 6/6 changed files
- Comments generated: 3
| import { ITelemetryService } from '../../../../../platform/telemetry/common/telemetry.js'; | ||
|
|
||
| const OPEN_AGENTS_WINDOW_COMMAND = 'workbench.action.openAgentsWindow'; | ||
| import { OPEN_AGENTS_WINDOW_COMMAND_ID } from '../../common/constants.js'; |
There was a problem hiding this comment.
The relative import path for OPEN_AGENTS_WINDOW_COMMAND_ID is incorrect. From chat/browser/agentSessions, ../../common/constants.js resolves to chat/browser/common, which doesn't exist; this should point to chat/common/constants.js (e.g. ../../../common/constants.js).
This issue also appears on line 38 of the same file.
Suggested change
| import { OPEN_AGENTS_WINDOW_COMMAND_ID } from '../../common/constants.js'; | |
| import { OPEN_AGENTS_WINDOW_COMMAND_ID } from '../../../common/constants.js'; |
alexr00
approved these changes
Apr 22, 2026
|
but why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.