Merged
Conversation
Member
connor4312
commented
Apr 22, 2026
connor4312
commented
- Unrelated: fix local agent host being broken on main following some overnight cleanups
- Register a JSON schema for agent session settings (only when they're open since it has a perf cost)
- When there are multiple custom approval buttons, show them in a dropdown similar to other tool calls.
- Unrelated: fix local agent host being broken on main following some overnight cleanups - Register a JSON schema for agent session settings (only when they're open since it has a perf cost) - When there are multiple custom approval buttons, show them in a dropdown similar to other tool calls.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the agent-host experience across the Sessions window and chat tool confirmations by restoring local agent-host wiring, adding lazy JSON schema registration for per-session settings files, and improving custom confirmation UX when multiple approval options exist.
Changes:
- Update tool confirmation rendering to group custom confirmation options into primary buttons with dropdowns.
- Add lazy, per-session JSON schema registration for
agent-session-settings://…documents and keep schemas updated as session config changes. - Fix Sessions window local agent-host by explicitly registering the agent host + terminal chat contributions.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/abstractToolConfirmationSubPart.ts | Groups custom confirmation options into approve/deny buttons with dropdowns. |
| src/vs/sessions/contrib/agentHost/test/browser/agentSessionSettingsFileSystemProvider.test.ts | Updates test harness to account for schema registrar + provider API additions. |
| src/vs/sessions/contrib/agentHost/browser/localAgentHost.contribution.ts | Registers agent-host workbench contributions for the Sessions window. |
| src/vs/sessions/contrib/agentHost/browser/agentSessionSettingsFileSystemProvider.ts | Adds schema conversion, schema registration/refresh logic, and injects schema registrar into FS provider. |
| src/vs/sessions/contrib/agentHost/browser/agentSessionSettings.contribution.ts | Instantiates and wires the schema registrar into the FS provider registration. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 5
roblourens
previously approved these changes
Apr 22, 2026
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/NeedsInput/Light
| Before | After |
|---|---|
 |
 |
pwang347
approved these changes
Apr 22, 2026
roblourens
added a commit
that referenced
this pull request
Apr 22, 2026
These two registerWorkbenchContribution2 calls landed on origin/main in f3d5d14 (#311954, 'agentHost: settings followups') after our last merge from origin/main. Without them the Agents app never instantiates AgentHostContribution, so authentication never runs and the local agent host stays in the loading state forever. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.