sessions: adjust notification placement and spacing#311959
Merged
hawkticehurst merged 1 commit intomainfrom Apr 22, 2026
Merged
sessions: adjust notification placement and spacing#311959hawkticehurst merged 1 commit intomainfrom
hawkticehurst merged 1 commit intomainfrom
Conversation
hawkticehurst
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts notification placement and offsets specifically for the Agents/Sessions standalone workbench (vs/sessions) without changing the shared VS Code workbench behavior.
Changes:
- Defaults
workbench.notifications.positiontobottom-rightfor sessions. - Adds sessions-scoped CSS to set notification center + toast offsets to
15pxfrom the relevant edges (and preservestop-rightastop: 40px; right: 15px). - Adds a sessions-only runtime override to re-apply the
top: 40pxoffset after shared notification controllers compute their inline top offsets, and updatesLAYOUT.mdaccordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts | Changes sessions default notification position to bottom-right. |
| src/vs/sessions/browser/workbench.ts | Adds sessions-only runtime logic to re-apply the fixed top-right top offset. |
| src/vs/sessions/browser/media/style.css | Adds sessions-scoped notification center/toast edge offsets (15px) and top-right center positioning. |
| src/vs/sessions/LAYOUT.md | Updates layout documentation and changelog to match the new placement/offset behavior. |
Default sessions notifications to bottom-right and tune the sessions-only notification center and toast offsets for each supported placement. Also reapply the sessions top-right offset after the shared notification controllers run so the sessions window keeps its intended 40px spacing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hawkticehurst
force-pushed
the
agents/update-notification-placement-sessions-app
branch
from
9331453 to
5ed81d5
Compare
Yoyokrazy
approved these changes
Apr 22, 2026
hawkticehurst
deleted the
agents/update-notification-placement-sessions-app
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates notification placement in the sessions app only.
workbench.notifications.positiontobottom-rightfor sessions15pxfrom the relevant bottom/right or bottom/left edgestop: 40px; right: 15pxin sessions, including a sessions-layer runtime override for the shared inline top offsetsrc/vs/sessions/LAYOUT.mdwith the implementation changesNotes
.agent-sessions-workbenchsrc/vs/sessions/browser/workbench.ts, so the shared workbench notification behavior is unchanged