Skip to content

add touch tap+click guidance for custom trigger elements in Agents#312001

Merged
rebornix merged 3 commits intomainfrom
rebornix/sessions-touch-instructions
Apr 23, 2026
Merged

add touch tap+click guidance for custom trigger elements in Agents#312001
rebornix merged 3 commits intomainfrom
rebornix/sessions-touch-instructions

Conversation

@rebornix
Copy link
Copy Markdown
Member

No description provided.

…sions instructions

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 22, 2026 20:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Agents window contributor instructions to improve touch/iOS handling guidance for custom clickable trigger elements in src/vs/sessions/.

Changes:

  • Adds guidance to handle both EventType.CLICK and TouchEventType.Tap for custom trigger elements that open pickers/menus, and to call Gesture.addTarget.
  • Keeps existing guidance about using generic mouse listeners and touch-action: manipulation for touch responsiveness.
Show a summary per file
File Description
.github/instructions/sessions.instructions.md Adds a new touch/iOS guideline for custom non-native clickable trigger elements in the Agents window.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread .github/instructions/sessions.instructions.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 82313c9c Current: 4318a46c

Changed (1)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rebornix rebornix merged commit 9932ad0 into main Apr 23, 2026
40 of 41 checks passed
@rebornix rebornix deleted the rebornix/sessions-touch-instructions branch April 23, 2026 04:26
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants