Open
Conversation
dmitrivMS
added
install-update
Contributor
|
Base:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses corrupted/non‑ASCII characters in the Windows installer context-menu strings by switching the Inno Setup .isl localization files to UTF‑8 with BOM and updating affected translations accordingly.
Changes:
- Replaces garbled text in multiple
build/win32/i18n/messages.*.islfiles with correct localized strings. - Updates several
build/win32/i18n/Default.*.islfiles to useLanguageCodePage=0for UTF‑8. - Updates
build/lib/i18n.tsto emit.islfiles as UTF‑8 with BOM (removing legacy codepage encoding).
Show a summary per file
| File | Description |
|---|---|
| build/win32/i18n/messages.zh-tw.isl | Fixes Traditional Chinese installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.zh-cn.isl | Fixes Simplified Chinese installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.tr.isl | Fixes Turkish installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.ru.isl | Fixes Russian installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.pt-br.isl | Fixes Brazilian Portuguese installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.ko.isl | Fixes Korean installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.ja.isl | Fixes Japanese installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.it.isl | Ensures Italian installer custom message file is UTF‑8 with BOM. |
| build/win32/i18n/messages.hu.isl | Fixes Hungarian installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.fr.isl | Fixes French installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.es.isl | Fixes Spanish installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/messages.en.isl | Ensures English installer message file is UTF‑8 with BOM. |
| build/win32/i18n/messages.de.isl | Fixes German installer custom message strings by writing proper UTF‑8 text/BOM. |
| build/win32/i18n/Default.zh-tw.isl | Updates Traditional Chinese default installer messages/codepage for UTF‑8. |
| build/win32/i18n/Default.zh-cn.isl | Updates Simplified Chinese default installer messages/codepage for UTF‑8. |
| build/win32/i18n/Default.ko.isl | Updates Korean default installer messages/codepage for UTF‑8. |
| build/win32/i18n/Default.hu.isl | Updates Hungarian default installer messages/codepage for UTF‑8. |
| build/lib/i18n.ts | Switches .isl generation to UTF‑8+BOM output (no codepage conversion). |
Copilot's findings
- Files reviewed: 18/18 changed files
- Comments generated: 4
dmitrivMS
changed the title
Contributor
Author
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293711
Switch loc files to UTF-8 which setup can now handle.
Verified by the customer who logged original bug the fix works on their machine.
Also verified in several locales that there are no regressions, but probably can do more coverage on those.