Agents: share keybindings, prompts and mcp from VS Code app#312083
Merged
Agents: share keybindings, prompts and mcp from VS Code app#312083
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the embedded Agents app to reuse selected user/profile resources from the host VS Code app so that keybindings, prompts, and MCP configuration are shared instead of duplicated.
Changes:
- Made
UserDataProfilesService.createDefaultProfile()extensible (protected) and overrode it in the electron-main implementation to point keybindings/prompts/MCP to the host VS CodeUser/directory when embedded. - Introduced
hostUserRoamingDataHomeon the environment service and used it to locate host VS Code roaming data. - Updated
StorageMainService(and its tests) to usehostUserRoamingDataHomefor host application DB fallback, removing theIProductServicedependency.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/userDataProfile/electron-main/userDataProfile.ts | Overrides default profile resources to read keybindings/prompts/MCP from the host VS Code user data when embedded. |
| src/vs/platform/userDataProfile/common/userDataProfile.ts | Makes createDefaultProfile() protected to allow native/electron-main customization. |
| src/vs/platform/storage/electron-main/storageMainService.ts | Switches host fallback DB path discovery to hostUserRoamingDataHome and removes IProductService injection. |
| src/vs/platform/storage/test/electron-main/storageMainService.test.ts | Updates tests for the StorageMainService constructor signature change. |
| src/vs/platform/environment/node/environmentService.ts | Implements hostUserRoamingDataHome for embedded app scenarios. |
| src/vs/platform/environment/common/environment.ts | Adds hostUserRoamingDataHome to the environment service interface. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 3
TylerLeonhardt
previously approved these changes
Apr 23, 2026
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
justschen
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.