Skip to content

cli plan widget improvements#312101

Merged
justschen merged 3 commits intomainfrom
justin/helioptile
Apr 24, 2026
Merged

cli plan widget improvements#312101
justschen merged 3 commits intomainfrom
justin/helioptile

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

Screen.Recording.2026-04-23.at.1.13.10.AM.mov

monaco scrollable, so things should render and scroll a bit better and not get hidden behind the provide feedback stuff
"edit plan.md" label removed - i think the pencil is enough tbh
swapped the chevron buttons (these were switched before. chevron up should be to expand. chevron down should be to close)
x next to "Additional feedback" so if you change ur mind, you can go back to the main widget to approve or continue.
better progress in the chat while a review item is shown
when an option is selected, we show in the chat what was selected (ie, "continued with autopilot", "rejected plan")
when we provide feedback, we show the feedback that was sent.

Copilot AI review requested due to automatic review settings April 23, 2026 08:48
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: f8d07504 Current: 2a291f94

Changed (1)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the chat “plan review” UX in the workbench chat widget by refining layout/scrolling behavior and by reflecting plan-review state transitions more clearly in the chat transcript.

Changes:

  • Render an inline “Plan review required” progress row (and suppress generic “Working” progress) while a plan review is pending; finalize “thinking” when a plan review blocks on user input.
  • Update plan review transcript behavior to show the selected outcome (and sent feedback) after completion.
  • UI polish for the plan review widget: scrollable body sizing, icon-only edit button, chevron direction fix, and an exit control for feedback mode.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Adds plan-review-specific progress rendering and state transitions in the response stream (and suppresses redundant working progress).
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css Refines sizing/scrolling and button row styling for the plan review widget, including feedback-mode layout constraints.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatPlanReviewPart.ts Updates plan review widget controls (icon-only edit, chevrons), adds feedback-mode close button, and keeps scroll geometry updated during textarea resize.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 5

Comment thread src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatPlanReviewPart.ts:464

  • When exiting feedback mode, the textarea value is cleared but its inline style.height (set by autoResize) is not reset. If a user re-enters feedback mode, the empty textarea can reopen at the previous (larger) height. Reset the textarea height when clearing (e.g. set height back to 'auto' / empty string) so the feedback UI returns to its collapsed size.
		if (this._feedbackTextarea) {
			this._feedbackTextarea.value = '';
			if (this.review instanceof ChatPlanReviewData) {
				this.review.draftFeedback = '';
			}
  • Files reviewed: 4/4 changed files
  • Comments generated: 1

@justschen justschen marked this pull request as ready for review April 24, 2026 00:12
@justschen justschen merged commit f3cd27d into main Apr 24, 2026
26 checks passed
@justschen justschen deleted the justin/helioptile branch April 24, 2026 08:27
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants