Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the chat “plan review” UX in the workbench chat widget by refining layout/scrolling behavior and by reflecting plan-review state transitions more clearly in the chat transcript.
Changes:
- Render an inline “Plan review required” progress row (and suppress generic “Working” progress) while a plan review is pending; finalize “thinking” when a plan review blocks on user input.
- Update plan review transcript behavior to show the selected outcome (and sent feedback) after completion.
- UI polish for the plan review widget: scrollable body sizing, icon-only edit button, chevron direction fix, and an exit control for feedback mode.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Adds plan-review-specific progress rendering and state transitions in the response stream (and suppresses redundant working progress). |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css | Refines sizing/scrolling and button row styling for the plan review widget, including feedback-mode layout constraints. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatPlanReviewPart.ts | Updates plan review widget controls (icon-only edit, chevrons), adds feedback-mode close button, and keeps scroll geometry updated during textarea resize. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 5
Contributor
There was a problem hiding this comment.
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatPlanReviewPart.ts:464
- When exiting feedback mode, the textarea value is cleared but its inline
style.height(set byautoResize) is not reset. If a user re-enters feedback mode, the empty textarea can reopen at the previous (larger) height. Reset the textarea height when clearing (e.g. set height back to'auto'/ empty string) so the feedback UI returns to its collapsed size.
if (this._feedbackTextarea) {
this._feedbackTextarea.value = '';
if (this.review instanceof ChatPlanReviewData) {
this.review.draftFeedback = '';
}
- Files reviewed: 4/4 changed files
- Comments generated: 1
joshspicer
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-04-23.at.1.13.10.AM.mov
monaco scrollable, so things should render and scroll a bit better and not get hidden behind the provide feedback stuff
"edit plan.md" label removed - i think the pencil is enough tbh
swapped the chevron buttons (these were switched before. chevron up should be to expand. chevron down should be to close)
x next to "Additional feedback" so if you change ur mind, you can go back to the main widget to approve or continue.
better progress in the chat while a review item is shown
when an option is selected, we show in the chat what was selected (ie, "continued with autopilot", "rejected plan")
when we provide feedback, we show the feedback that was sent.