sessions: fix missing remote toggle for local agent host, duplicate permissions setting#312198
Merged
connor4312 merged 2 commits intomainfrom Apr 23, 2026
Merged
sessions: fix missing remote toggle for local agent host, duplicate permissions setting#312198connor4312 merged 2 commits intomainfrom
connor4312 merged 2 commits intomainfrom
Conversation
…ermissions setting
connor4312
force-pushed
the
connor4312/ah-fix-actions
branch
from
466a3a7 to
f3b2321
Compare
The import was declared but never used in the file, causing a TS6133 compilation error.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts chat input secondary-toolbar actions to better match agent session types, ensuring the “Allow Remote Connections” toggle appears for local agent-host sessions and reducing redundant permission UI in locked agent sessions.
Changes:
- Updates the permission picker visibility condition to only show when unlocked or locked to specific providers (Background/Claude).
- Broadens the “Allow Remote Connections” toggle visibility to any
agent-host-*locked session via regex. - Refines context-key driven UI gating for sessions-specific toolbar actions.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts | Narrows when the permission picker is shown in the chat input secondary toolbar based on locked session provider. |
| src/vs/sessions/contrib/tunnelHost/electron-browser/tunnelHost.contribution.ts | Makes the remote-connections toggle appear for all agent-host-* sessions instead of only agent-host-copilot. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
benvillalobos
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.