Skip to content

sessions: add tip banner for sub-session creation#312203

Merged
hawkticehurst merged 3 commits intomainfrom
agents/add-tip-ui-for-subsession-creation
Apr 23, 2026
Merged

sessions: add tip banner for sub-session creation#312203
hawkticehurst merged 3 commits intomainfrom
agents/add-tip-ui-for-subsession-creation

Conversation

@hawkticehurst
Copy link
Copy Markdown
Member

@hawkticehurst hawkticehurst commented Apr 23, 2026

Shows a dismissable tip banner above the chat input when a new sub-session is created via the "New Sub-Session" button in the titlebar. The tip concisely explains what a sub-session is — a new chat within the same workspace for asking questions, running tasks, or exploring ideas with fresh context.

Screenshot 2026-04-23 at 3 14 57 PM

Changes

  • newChatInSessionViewPane.ts: Added _renderSubSessionTip() to render a tip widget (lightbulb icon + message + dismiss button) above the chat input. Dismissal is persisted to StorageScope.PROFILE so the tip only shows once.
  • newChatInSession.css: Added styles for the tip banner matching the existing core chat tip pattern, with seamless visual connection to the input area below (shared border, connected border-radius).

Visual pattern

The tip follows the same design as the existing ChatTipContentPart in VS Code core — a horizontal banner with icon, text, and dismiss action that sits directly above the chat input with connected borders.

Shows a dismissable tip above the chat input when a new sub-session is
created, explaining what a sub-session is and how to use it. The tip
uses the same visual pattern as the core chat tip widget and persists
dismissal to the user's profile storage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 19:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a one-time, dismissable “sub-session” tip banner to the Sessions window’s “new chat in session” input area, with dismissal persisted in profile-scoped storage.

Changes:

  • Render a tip banner (icon + explanatory text + dismiss control) above the chat input and persist dismissal via IStorageService.
  • Add CSS to visually connect the banner and input area (shared border treatment / connected corner radii).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/vs/sessions/contrib/chat/browser/newChatInSessionViewPane.ts Renders the sub-session tip UI and persists dismissal state.
src/vs/sessions/contrib/chat/browser/media/newChatInSession.css Styles the tip banner and adjusts input border radii when the banner is present.

Comment thread src/vs/sessions/contrib/chat/browser/newChatInSessionViewPane.ts Outdated
Comment thread src/vs/sessions/contrib/chat/browser/newChatInSessionViewPane.ts Outdated
Comment thread src/vs/sessions/contrib/chat/browser/media/newChatInSession.css
- Use native <button> instead of <a> with role=button for dismiss control
- Add Gesture.addTarget and TouchEventType.Tap listener for iOS/touch
- Add touch-action: manipulation and reset native button styles in CSS

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

Screenshot Changes

Base: f46e6eb9 Current: 70f06916

Changed (1)

sessions/sessionsPolicyBlocked/Loading/Dark
Before After
before after

TylerLeonhardt
TylerLeonhardt previously approved these changes Apr 23, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hawkticehurst hawkticehurst merged commit 48c11b5 into main Apr 23, 2026
26 checks passed
@hawkticehurst hawkticehurst deleted the agents/add-tip-ui-for-subsession-creation branch April 23, 2026 22:51
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants