Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a developer tools warning in the Agents (Sessions) window by correcting how the Changes view container is instantiated.
Changes:
- Remove extraneous constructor arguments from the
SyncDescriptorused to createChangesViewPaneContainer. - Rely on
ChangesViewPaneContainer’s constructor (which already hard-codes the container id/options in itssuper(...)call) to provide the container configuration.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/changes/browser/changes.contribution.ts |
Updates the view container ctorDescriptor to avoid passing unused args that trigger instantiation/devtools warnings. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
benvillalobos
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.