Suppress rate-limit/quota-exceeded errors from chatAgentError telemetry#312239
Merged
bryanchen-d merged 3 commits intomainfrom Apr 23, 2026
Merged
Suppress rate-limit/quota-exceeded errors from chatAgentError telemetry#312239bryanchen-d merged 3 commits intomainfrom
bryanchen-d merged 3 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/dee4acf8-b202-4573-95cc-3c68fed13e01 Co-authored-by: bryanchen-d <41454397+bryanchen-d@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Suppress rate limits exceeded from agents error reporting
Suppress rate-limit/quota-exceeded errors from chatAgentError telemetry
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces noise in workbench telemetry by suppressing chatAgentError telemetry for expected operational failures (rate limiting / quota exceeded) coming from chat agent invocation, while leaving UI error handling unchanged.
Changes:
- Add a guard to skip
publicLogError2('chatAgentError')whenrpcResult.errorDetails?.isRateLimitedorisQuotaExceededis set. - Document the rationale inline and link to the tracking issue.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/api/browser/mainThreadChatAgents2.ts |
Prevents logging expected rate-limit/quota errors to chatAgentError telemetry while preserving error details for the UI layer. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
bryanchen-d
approved these changes
Apr 23, 2026
zhichli
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatRateLimitederrors thrown by the Copilot extension's_provideLanguageModelResponsewere surfacing as unhandled errors in thechatAgentErrortelemetry, despite being expected operational conditions that are already handled gracefully in the UI.Changes
src/vs/workbench/api/browser/mainThreadChatAgents2.ts: Skip thepublicLogError2('chatAgentError')call whenrpcResult.errorDetails?.isRateLimitedorisQuotaExceededis set. Both flags are already populated upstream inextHostChatAgents2.tsbased on the error name (ChatRateLimited/ChatQuotaExceeded), so no additional plumbing is needed. The error details continue to flow to the UI layer unchanged.This corresponds to "fix location 2" from the investigation comment on the issue.