Merged
Conversation
… right-aligned descriptions - Remove source grouping from workspace picker; show a flat recency-sorted list - Browse actions grouped by 'group' property instead of label comparison - When multiple providers share a group, show a single entry with a submenu - Each browse action carries an optional description (Local, GitHub, provider name) - Browse action descriptions shown right-aligned using group title in inline-description mode - ActionList: submenu items use action icon via group.icon - ActionList: fix group-title right-alignment in inline-description mode (margin-left: auto) - ActionList: remove fixedWidth option (no remaining consumers) - ISessionWorkspaceBrowseAction: add optional description and group fields Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sandy081
force-pushed
the
sandy081/workspace-picker-improvements
branch
from
a9960f4 to
6610927
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the Agents window session workspace picker UX by flattening and recency-sorting workspace entries, and by surfacing provider “browse/select” actions directly in the main list with optional grouping into submenus.
Changes:
- Extend
ISessionWorkspaceBrowseActionwith optionaldescriptionandgroupmetadata to support richer picker rendering. - Rework workspace picker item construction to remove provider/source grouping and add grouped/ungrouped browse actions in the main list.
- Update ActionList styling/rendering to improve group-title alignment in inline-description mode and support submenu item icons; remove the unused
fixedWidthoption.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/services/sessions/common/session.ts | Adds description/group to browse action contract for workspace picker UI. |
| src/vs/sessions/contrib/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts | Adds browse action description/group metadata for remote agent host folders action. |
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts | Adds browse action descriptions (e.g. “Local”, “GitHub”) and groups folder actions. |
| src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts | Implements flat recency list and grouped browse actions with submenu support. |
| src/vs/sessions/contrib/agentHost/browser/localAgentHostSessionsProvider.ts | Adds browse action description/group metadata for local agent host folders action. |
| src/vs/platform/actionWidget/browser/actionWidget.css | Fixes inline-description group-title alignment by pushing it to the right. |
| src/vs/platform/actionWidget/browser/actionList.ts | Adds submenu icon support and removes fixedWidth sizing option. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 2
Comment on lines
+433
to
437
| label: localize('workspacePicker.browseSelectAction', "Select {0}...", label), | ||
| group: { title: '', icon }, | ||
| item: {}, | ||
| submenuActions: [new SubmenuAction(`workspacePicker.browse.group.${label}`, '', submenuActions)], | ||
| }); |
There was a problem hiding this comment.
The SubmenuAction id is built from label (a localized UI string): workspacePicker.browse.group.${label}. Action ids should be stable and non-localized; using localized text can cause id changes across locales and potential collisions. Use the non-localized group key (e.g. the Map key from browseByGroup) or another stable identifier instead.
roblourens
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improvements to the session workspace picker UX:
Flat recency-sorted list
Remove source/provider grouping — workspaces now appear in a flat list sorted by most recently used, so the last-used agent host workspace shows at the top regardless of provider.
Browse actions in main list
Replace the single
Select...submenu entry with individual browse actions shown directly in the main picker list.Browse action grouping by
grouppropertydescription,group, and icon support toISessionWorkspaceBrowseActiongroupkey are merged into one entry with a submenu (e.g. all'folders'actions becomeSelect Folders...with provider sub-entries)groupare shown individuallyAction list improvements
margin-left: auto) so titles are always right-aligned even when description is absentgroup.iconmechanism (read from action'siconproperty)fixedWidthoption (no remaining callers)