sessions: update Open in VS Code titlebar button with hover animation and full-color icon#312250
Merged
lostintangent merged 7 commits intomainfrom Apr 24, 2026
Merged
Conversation
roblourens
approved these changes
Apr 23, 2026
roblourens
previously requested changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Agents/Sessions titlebar “Open in VS Code” entry to use a richer, expandable widget (icon-only at rest, label on hover/focus) and aligns menu ordering, while adding a dev-mode fallback for launching VS Code via protocol handler when a sibling app isn’t configured.
Changes:
- Adds a custom
BaseActionViewItem-based titlebar widget with hover/focus expand animation and a full-color VS Code logo asset + styling. - Reorders the “Open in VS Code” titlebar action earlier in the navigation group (order
9→7) and updates related ordering comments. - Enhances the electron-browser implementation to prefer
launchSiblingAppwhen configured, with a protocol-handler fallback for dev scenarios.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/chat/electron-browser/openInVSCode.contribution.ts | Adds sibling-app detection and protocol-handler fallback logic for opening VS Code from the Sessions window. |
| src/vs/sessions/contrib/chat/browser/openInVSCodeWidget.ts | Introduces the custom expandable titlebar widget and registers it via IActionViewItemService. |
| src/vs/sessions/contrib/chat/browser/openInVSCode.contribution.ts | Adjusts the titlebar menu order for the action. |
| src/vs/sessions/contrib/chat/browser/media/openInVSCode.css | Adds styling for hover/focus expansion, grayscale→color transition, and quality-tinted hover backgrounds. |
| src/vs/sessions/contrib/chat/browser/media/vscode-icon.svg | Adds a dev-time fallback full-color VS Code logo asset. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Imports the new widget module to register it at runtime. |
| src/vs/sessions/contrib/changes/browser/changesTitleBarWidget.ts | Updates the ordering comment to reflect the new menu order. |
… and full-color icon - Add custom BaseActionViewItem widget that renders the Open in VS Code button with a slide-in label animation on hover/focus and a full-color VS Code logo that desaturates at rest via CSS filter - Reorder the button before the Run Tasks button (order 7 vs 8) - Use ICommandService.executeCommand directly in onClick to bypass precondition-gated ActionRunner.run() which silently blocked clicks - Add protocol handler fallback in electron-browser action for dev builds where no sibling app is configured (launchSiblingApp fails) - Quality-tinted hover backgrounds (blue/green/orange) based on product quality, matching the companion Open in Agents button in VS Code core Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hawkticehurst
force-pushed
the
agents/update-titlebar-open-vscode-button
branch
from
1aa55e1 to
29178d2
Compare
- Only set data-product-quality attribute when productService.quality is defined (not in dev builds where quality is undefined) - CSS default background-image uses the bundled ./vscode-icon.svg shield (shown in dev builds where no quality attribute is present) - Added per-quality CSS rules pointing to ../../../../../workbench/browser/media/code-icon.svg — the file that vscode-distro overwrites at packaging time with the quality-specific branded VS Code icon (stable/insider/exploration) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- widget: replace ICommandService.executeCommand with this.action.run() and remove the now-unused ICommandService dependency - electron contribution: also check productService.embedded fields in hasSibling to align with launchSiblingApp's own resolution logic in siblingApp.ts which switches on process.isEmbeddedApp - CSS: scope filter and label transitions inside .monaco-enable-motion blocks and add .monaco-reduce-motion overrides, following the pattern established by other sessions titlebar widgets Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: sandy081 <10746682+sandy081@users.noreply.github.com>
Contributor
Resolved the merge conflict in |
sandy081
approved these changes
Apr 24, 2026
sandy081
previously requested changes
Apr 24, 2026
lostintangent
approved these changes
Apr 24, 2026
hawkticehurst
dismissed stale reviews from sandy081 and roblourens
Feedback was addressed. Dismissing in order to merge.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #310014
Updates the "Open in VS Code" button in the Agents/Sessions titlebar with a rich expandable widget, mirroring the companion "Open in Agents" button in VS Code core (PR #312111).
Screen.Recording.2026-04-23.at.6.42.47.PM.mov
Changes
New widget with hover animation
BaseActionViewItemwidget (OpenInVSCodeTitleBarWidget) registered viaIActionViewItemServicemax-widthtransitionfilter: grayscale(1)touch-action: manipulationVS Code icon — dev fallback + distro integration
media/vscode-icon.svg— the VS Code shield logo bundled in the repo, used as a dev-time fallback whenproductService.qualityis undefinedvs/workbench/browser/media/code-icon.svgwith the quality-specific branded icon (stable/insider/exploration). The CSS[data-product-quality]attribute selectors switch to that path for all known qualitiesdata-product-qualityis only set on the widget element whenproductService.qualityis defined, ensuring the fallback SVG is shown in dev buildsButton reordering
Click fix
ICommandService.executeCommand()directly inonClickoverride to bypass the precondition-gatedActionRunner.run()check that silently blocked clicks when theMenuItemActionwas marked disabledDev fallback for electron-browser action
IOpenerService) for dev builds where no sibling app is configured (darwinSiblingBundleIdentifier/win32SiblingExeBasenameabsent)INativeHostService.launchSiblingAppas beforeFiles changed
openInVSCodeWidget.tsmedia/openInVSCode.cssmedia/vscode-icon.svgcode-icon.svgtakes precedence in prod)electron-browser/openInVSCode.contribution.tsbrowser/openInVSCode.contribution.tschat.contribution.tschangesTitleBarWidget.ts