agentHost: fix duplicate edits being shown in chat#312252
Merged
connor4312 merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicate UI for tool-generated file edits in chat by hiding the tool invocation widget when file edits are already rendered separately (via the file-edits callback), ensuring only one representation is shown.
Changes:
- Hide tool invocation UI on successful completion when file edits are present (
ToolInvocationPresentation.Hidden). - Extract file edits before transitioning the invocation to “completed” so the hide presentation is applied before re-render.
- Update
ChatToolInvocationPartrendering to respectToolInvocationPresentation.Hidden(not justHiddenAfterComplete).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolInvocationPart.ts | Hides the tool invocation part when presentation is Hidden, preventing duplicate rendering. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/stateToProgressAdapter.ts | Sets tool invocation presentation to Hidden when successful completions contain file edits, and adjusts ordering to hide before completion re-render. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
roblourens
previously approved these changes
Apr 23, 2026
When a tool call produces file edits, the onFileEdits callback already hydrates edit pills into the chat response. However, the tool invocation widget was also remaining visible, leading to duplicate UI. - Set presentation to Hidden on tool invocations that complete successfully with file edits in finalizeToolInvocation - Move file edit extraction before didExecuteTool so the presentation is set before the completion state transition triggers re-render - Add handling for ToolInvocationPresentation.Hidden in the render function of ChatToolInvocationPart (previously only checked HiddenAfterComplete) (Commit message generated by Copilot)
connor4312
force-pushed
the
connor4312/fix-duplicate-edit-pills
branch
from
8a717d1 to
e98cff7
Compare
TylerLeonhardt
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentHost: fix duplicate edits being shown in chat
When a tool call produces file edits, the onFileEdits callback already
hydrates edit pills into the chat response. However, the tool invocation
widget was also remaining visible, leading to duplicate UI.
successfully with file edits in finalizeToolInvocation
is set before the completion state transition triggers re-render
function of ChatToolInvocationPart (previously only checked
HiddenAfterComplete)
(Commit message generated by Copilot)